fix(plugins/metric_system_v2): report fd metrics as string to avoid float64 precision loss#2487
Open
zhang-guodong wants to merge 1 commit into
Open
fix(plugins/metric_system_v2): report fd metrics as string to avoid float64 precision loss#2487zhang-guodong wants to merge 1 commit into
zhang-guodong wants to merge 1 commit into
Conversation
Collaborator
|
百炼自动化审查：建议保持开启。 本 PR 针对 metric_system_v2 插件中 fd 指标上报时的 float64 精度丢失问题提出了有效修复，改为字符串上报。经核对，该改动尚未合入 main 分支，且属于合理的核心插件缺陷修复，应保持开启供维护者审查与合并。. 最佳落地路径： 建议维护者审查本 PR 的改动范围与下游指标消费端对字符串类型值的兼容性。若 CI 通过且无破坏性变更，可直接合并；或根据 PR 正文讨论评估是否直接移除恒定的 fd_max 指标以简化逻辑。. 已核对内容：
百炼审查备注：模型 qwen3.6-max-preview；对照提交 30ac854deafd。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
I noticed that input plugin metric_system_v2 reports fd_max as float64. However, fd_max is fixed at max int64(2^63-1 or 9223372036854775807), which exceeds the range of float64. Therefore, the data, with its loss of precision, is represented as 9.223372036854776e+18 in Metric.
loongcollector/plugins/input/systemv2/input_system_linux.go
Lines 166 to 169 in 68ba314
Since the metric is eventually converted to a string (see log_helper.go#L258), it would be more accurate to record fd_max directly as a string.
Alternatively, how about considering simply removing fd_max, since it's a constant on Linux anyway?